Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresqlPackages.pgvecto-rs: fix build failure on rust 1.78 #320302

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

diogotcorreia
Copy link
Member

@diogotcorreia diogotcorreia commented Jun 16, 2024

Description of changes

Fixes #320131

Currently running tests for all supported postgresql versions (at least 14 seems to be building). Tests succeeded.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from esclear June 16, 2024 17:49
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jun 16, 2024
@anoadragon453
Copy link
Member

anoadragon453 commented Jun 16, 2024

I can confirm that this fixes #320131 in my NixOS Immich setup. Thank you!

@anoadragon453 anoadragon453 mentioned this pull request Jun 16, 2024
16 tasks
@diogotcorreia diogotcorreia marked this pull request as ready for review June 16, 2024 19:10
@diogotcorreia
Copy link
Member Author

@happysalada while the upgrade to v0.3.0 is halted (#321617), could you review this one if you don't mind?
That way, we avoid the broken package meanwhile

@happysalada happysalada merged commit c07812f into NixOS:master Jun 23, 2024
29 checks passed
@diogotcorreia diogotcorreia deleted the pgvecto-rs-fix-rust-1-78 branch June 23, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: cargo-pgrx
3 participants